Issue 7309012: Don't try to build d8 from profiler tick processor scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7309012: Don't try to build d8 from profiler tick processor scripts. (Closed)

Created:
9 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 5 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Don't try to build d8 from profiler tick processor scripts. As described in the issue 1532, this may lead to building a 32-bit version over existing x64-bit. It's better delegate to delegate this task to an user. R=vitalyr@chromium.org BUG=1532 Committed: http://code.google.com/p/v8/source/detail?r=8530

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	tools/linux-tick-processor	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM Do we need some benchmarking infrastructure updates after this change?

9 years, 5 months ago (2011-07-04 22:49:50 UTC) #2

mnaganov (inactive)

9 years, 5 months ago (2011-07-05 05:25:11 UTC) #3

On 2011/07/04 22:49:50, Vitaly Repeshko wrote:
> LGTM
> 
> Do we need some benchmarking infrastructure updates after this change?

As far as I can see from its sources, d8 is either built together with a VM, or
is pre-built. Anyway, on Windows the tick processor never builds d8, and this
model works just fine.

Expand Messages | Collapse Messages