chrome/installer/setup/eula/oem.js - Issue 7309008: Change the system-level EULA dialog to not use GET parameters with res:// urls. Instead use the d...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/eula/oem.js

Issue 7309008: Change the system-level EULA dialog to not use GET parameters with res:// urls. Instead use the d... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/eula/oem.js

===================================================================

--- chrome/installer/setup/eula/oem.js (revision 91469)

+++ chrome/installer/setup/eula/oem.js (working copy)

@@ -1,8 +1,8 @@

function setInnerFrame() {

- var regex = new RegExp("\\?innerframe=\"?([^&#\"]*)\"?");

- var results = regex.exec(window.location.href);

- if(results && results[1])

- document.getElementById('ifr').src = results[1];

+ if (window.dialogArguments) {

+ var inner_frame = window.dialogArguments;

+ document.getElementById('ifr').src = inner_frame;

grt (UTC plus 2) 2011/07/04 18:42:04 why not something like: if (inner_frame && inner_f

robertshield 2011/07/04 19:12:31 Good idea, the empty string evaluates to false, so

+ }

}

function checkAccept(f) {

« no previous file with comments | « no previous file | chrome/installer/setup/setup_main.cc » ('j') | chrome/installer/util/html_dialog.h » ('J')