Change the system-level EULA dialog to not use GET parameters with res:// urls. Instead use the d...

chrome/installer/util/html_dialog.h

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_HTML_DIALOG_H_
 #define CHROME_INSTALLER_UTIL_HTML_DIALOG_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 51 matching lines @@
 // different underlying implementation according to the url protocol.
 HTMLDialog* CreateNativeHTMLDialog(const std::wstring& url);
 
 // This class leverages HTMLDialog to create a dialog that is suitable
 // for a end-user-agreement modal dialog. The html shows a fairly standard
 // EULA form with the accept and cancel buttons and an optional check box
 // to opt-in for sending usage stats and crash reports.
 class EulaHTMLDialog {
  public:
   // |file| points to an html file on disk or to a resource via res:// spec.
-  explicit EulaHTMLDialog(const std::wstring& file);
+   explicit EulaHTMLDialog(const std::wstring& file,

[grt (UTC plus 2), 2011/07/04 18:42:04]

please remove "explicit" since this is no longer a one-arg ctor and add a
description of |param| to the comment.

[robertshield, 2011/07/04 19:12:31]

Done.

+                           const std::wstring& param);
   ~EulaHTMLDialog();
 
   enum Outcome {
     REJECTED,           // Declined EULA, mapped from HTML_DLG_ACCEPT (1).
     ACCEPTED,           // Accepted EULA no opt-in, from HTML_DLG_DECLINE (2).
     ACCEPTED_OPT_IN,    // Accepted EULA and opt-in, from HTML_DLG_EXTRA (6).
   };
 
   // Shows the dialog and blocks for user input. The return value is one of
   // the |Outcome| values and any form of failure maps to REJECTED.
   Outcome ShowModal();
 
  private:
   class Customizer : public HTMLDialog::CustomizationCallback {
    public:
     virtual void OnBeforeCreation(void** extra);
     virtual void OnBeforeDisplay(void* window);
   };
 
   HTMLDialog* dialog_;
   DISALLOW_COPY_AND_ASSIGN(EulaHTMLDialog);
 };
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_HTML_DIALOG_H_