Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 7309002: Fix a bug in with and catch context allocation. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in with and catch context allocation. We were only looking one level up the scope chain to decide which closure to use in the fresh context. Instead, we should look to the first non-catch scope. R=vegorov@chromium.org BUG=1528 TEST=regress-1528 Committed: http://code.google.com/p/v8/source/detail?r=8523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -31 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/parser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.cc View 7 chunks +6 lines, -14 lines 0 comments Download
M src/scopes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/scopes.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-1528.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 5 months ago (2011-07-04 09:29:05 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-07-04 09:32:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698