Issue 73076: Fix crash bug when loading const variable in the presence of eval....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73076: Fix crash bug when loading const variable in the presence of eval.... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix crash bug when loading const variable in the presence of eval. The problem was a missing 'uninitialized' check. Committed: http://code.google.com/p/v8/source/detail?r=1713

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -0 lines)			Patch
M	src/codegen-arm.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 chunk	+5 lines, -0 lines	1 comment	Download
A	test/mjsunit/const-declaration.js	View	1 chunk	+172 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/73076/diff/1/4 File src/codegen-ia32.cc (right): http://codereview.chromium.org/73076/diff/1/4#newcode3294 Line 3294: // There is always control flow to ...

11 years, 8 months ago (2009-04-15 10:42:54 UTC) #2

Mads Ager (chromium)

11 years, 8 months ago (2009-04-15 10:53:31 UTC) #3

On 2009/04/15 10:42:54, Kevin Millikin wrote:
> LGTM.
> 
> http://codereview.chromium.org/73076/diff/1/4
> File src/codegen-ia32.cc (right):
> 
> http://codereview.chromium.org/73076/diff/1/4#newcode3294
> Line 3294: // There is always control flow to slow from
> This comment isn't explicit enough.  Could you add "so we have to jump around
> it." here and in the ARM version?

Done.

Expand Messages | Collapse Messages