Issue 73075: First step to port file_util::CountFilesCreatedAfter()....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73075: First step to port file_util::CountFilesCreatedAfter().... (Closed)

Created:
11 years, 8 months ago by hamaji

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

First step to port file_util::CountFilesCreatedAfter(). CountFileCreatedAfter() takes FilePath and Time instead of wstring and FILETIME. We still need to implement the function for POSIX. I'll work on the change after this change. BUG=9833

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -34 lines)			Patch
M	base/file_util.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	base/file_util_unittest.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	base/file_util_win.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hamaji

Hi, I'm trying to fix issues filed to get familiar with chrome code base. Now ...

11 years, 8 months ago (2009-04-15 08:26:07 UTC) #1

hamaji

11 years, 8 months ago (2009-04-15 15:55:39 UTC) #3

On 2009/04/15 15:47:17, Erik Kay wrote:
> LGTM

Thanks you for the review! I don't have permission to check this in. Could you
submit this, please?

Thanks,

Expand Messages | Collapse Messages