C++ File IO documentation.

C++ File IO documentation.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96083

[sanga, 2011-07-08 00:54:49]

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h
File ppapi/cpp/file_io.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h#newcode30
ppapi/cpp/file_io.h:30: /// return value whose reference count we need to
increment.
return value?

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h
File ppapi/cpp/file_ref.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h#newcode31
ppapi/cpp/file_ref.h:31: /// return value whose reference count we need to
increment.
return value?

[jond, 2011-07-08 15:22:35]

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h
File ppapi/cpp/file_io.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h#newcode30
ppapi/cpp/file_io.h:30: /// return value whose reference count we need to
increment.
Right, I believe you use this constructor and pass it an Instance when we need
to refcount the instance. I'll copy David on this too.

On 2011/07/08 00:54:49, sanga wrote:
> return value?

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h
File ppapi/cpp/file_ref.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h#newcode31
ppapi/cpp/file_ref.h:31: /// return value whose reference count we need to
increment.
See previous

On 2011/07/08 00:54:49, sanga wrote:
> return value?

[dmichael (off chromium), 2011-07-08 15:29:00]

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h
File ppapi/cpp/file_io.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h#newcode30
ppapi/cpp/file_io.h:30: /// return value whose reference count we need to
increment.
On 2011/07/08 15:22:35, jond wrote:
> Right, I believe you use this constructor and pass it an Instance when we need
> to refcount the instance. I'll copy David on this too.
> 
> On 2011/07/08 00:54:49, sanga wrote:
> > return value?
> 
The current woding doesn't make sense to me. It's really just constructing the
FileIO and associating it with the given Instance, kind of like
PPB_File_IO.Create says:
  /**
   * Create() creates a new FileIO object.
   *
   * @param[in] instance A <code>PP_Instance</code> indentifying the instance
   * with the file.
   *
   * @return A <code>PP_Resource</code> corresponding to a FileIO if
   * successful or 0 if the module is invalid.
   */
  PP_Resource (*Create)(PP_Instance instance);

[jond, 2011-07-08 15:35:53]

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h
File ppapi/cpp/file_io.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_io.h#newcode30
ppapi/cpp/file_io.h:30: /// return value whose reference count we need to
increment.
On 2011/07/08 15:29:00, dmichael1 wrote:
> On 2011/07/08 15:22:35, jond wrote:
> > Right, I believe you use this constructor and pass it an Instance when we
need
> > to refcount the instance. I'll copy David on this too.
> > 
> > On 2011/07/08 00:54:49, sanga wrote:
> > > return value?
> > 
> The current woding doesn't make sense to me. It's really just constructing the
> FileIO and associating it with the given Instance, kind of like
> PPB_File_IO.Create says:
>   /**
>    * Create() creates a new FileIO object.
>    *
>    * @param[in] instance A <code>PP_Instance</code> indentifying the instance
>    * with the file.
>    *
>    * @return A <code>PP_Resource</code> corresponding to a FileIO if
>    * successful or 0 if the module is invalid.
>    */
>   PP_Resource (*Create)(PP_Instance instance);
> 

Done.

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h
File ppapi/cpp/file_ref.h (right):

http://codereview.chromium.org/7307037/diff/1/ppapi/cpp/file_ref.h#newcode31
ppapi/cpp/file_ref.h:31: /// return value whose reference count we need to
increment.
On 2011/07/08 15:22:35, jond wrote:
> See previous
> 
> On 2011/07/08 00:54:49, sanga wrote:
> > return value?
> 

Done.

[Sang Ahn, 2011-07-08 16:13:32]

lgtm

[dmichael (off chromium), 2011-07-08 16:15:57]

rubber-stamp LGTM

[commit-bot: I haz the power, 2011-07-08 18:00:14]

Change committed as 91876