Add inspection of whether frame is a construct frame to optimized frames

src/runtime.cc

Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 2e0df5001bcfd9435bf5d1e8e62b5cc79ae473ac..5545a55105bc07454921fb10fcdf8bed1563ae89 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -10060,7 +10060,13 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GetFrameDetails) {
       it.frame()->LookupCode()->SourcePosition(it.frame()->pc());
 
   // Check for constructor frame.
-  bool constructor = it.frame()->IsConstructor();
+  bool constructor;
+  if (it.frame()->is_optimized() && deoptimized_frame_index != 0) {
+    // Inlined frames cannot be construct calls.
+    constructor = false;
+  } else {
+    constructor = it.frame()->IsConstructor();
+  }

[Sven Panne, 2011/07/08 08:17:37]

This is a bit hard to read, perhaps:

bool inlined_frame = it.frame()->is_optimized() && deoptimized_frame_index != 0;
bool constructor = !inlined_frame && it.frame()->IsConstructor();

http://www.refactoring.com/catalog/introduceExplainingVariable.html ;-)

Or even better: Can this be moved into IsConstructor? It's a bit hard for me to
judge from its uses.

[Søren Thygesen Gjesse, 2011/07/08 08:43:09]

Done. It cannot go into IsConstructor as IsConstructor is a method on the "real"
stack frame for the optimized function containing inlined functions.

 
   // Get scope info and read from it for local variable information.
   Handle<JSFunction> function(JSFunction::cast(it.frame()->function()));