Add inspection of whether frame is a construct frame to optimized frames

src/runtime.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10042 matching lines @@
   ASSERT(save != NULL);
 
   // Get the frame id.
   Handle<Object> frame_id(WrapFrameId(it.frame()->id()), isolate);
 
   // Find source position.
   int position =
       it.frame()->LookupCode()->SourcePosition(it.frame()->pc());
 
   // Check for constructor frame.
-  bool constructor = it.frame()->IsConstructor();
+  bool constructor;
+  if (it.frame()->is_optimized() && deoptimized_frame_index != 0) {
+    // Inlined frames cannot be construct calls.
+    constructor = false;
+  } else {
+    constructor = it.frame()->IsConstructor();
+  }

[Sven Panne, 2011/07/08 08:17:37]

This is a bit hard to read, perhaps:

bool inlined_frame = it.frame()->is_optimized() && deoptimized_frame_index != 0;
bool constructor = !inlined_frame && it.frame()->IsConstructor();

http://www.refactoring.com/catalog/introduceExplainingVariable.html ;-)

Or even better: Can this be moved into IsConstructor? It's a bit hard for me to
judge from its uses.

[Søren Thygesen Gjesse, 2011/07/08 08:43:09]

Done. It cannot go into IsConstructor as IsConstructor is a method on the "real"
stack frame for the optimized function containing inlined functions.

 
   // Get scope info and read from it for local variable information.
   Handle<JSFunction> function(JSFunction::cast(it.frame()->function()));
   Handle<SerializedScopeInfo> scope_info(function->shared()->scope_info());
   ASSERT(*scope_info != SerializedScopeInfo::Empty());
   ScopeInfo<> info(*scope_info);
 
   // Get the locals names and values into a temporary array.
   //
   // TODO(1240907): Hide compiler-introduced stack variables
@@ skipping 2536 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     isolate->counters()->gc_last_resort_from_js()->Increment();
     isolate->heap()->CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal