Issue 7307034: Create ChromeWebUIFactory when testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7307034: Create ChromeWebUIFactory when testing. (Closed)

Created:
9 years, 5 months ago by Sheridan Rawlins

Modified:
9 years, 5 months ago

Reviewers:
Lei Zhang, commit-bot: I haz the power, sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Create ChromeWebUIFactory when testing. R=sky@chromium.org BUG=88532 TEST=browser_tests --gtest_filter=TestWebUIFactory*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91734

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/ui/webui/test_chrome_web_ui_factory_browsertest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/web_ui_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Sheridan Rawlins

Scott, can you review whether the following is safe? i.e. should the fix be to ...

9 years, 5 months ago (2011-07-07 06:53:29 UTC) #2

sky

LGTM From WebUI: // NOTE: If you're creating a new WebUI for Chrome code, make ...

9 years, 5 months ago (2011-07-07 16:05:37 UTC) #3

LGTM++