remoting/host/heartbeat_sender.cc - Issue 7307031: Remove DCHECK from HeartbeatSender::OnSignallingDisconnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/heartbeat_sender.cc

Issue 7307031: Remove DCHECK from HeartbeatSender::OnSignallingDisconnected() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/heartbeat_sender.cc

diff --git a/remoting/host/heartbeat_sender.cc b/remoting/host/heartbeat_sender.cc

index ad87658fc5f9cd113058abf13f49420f5ebddfe6..1e3dd388cd17a50a277a60e4026567b3b9188e45 100644

--- a/remoting/host/heartbeat_sender.cc

+++ b/remoting/host/heartbeat_sender.cc

@@ -81,9 +81,10 @@ void HeartbeatSender::OnSignallingConnected(SignalStrategy* signal_strategy,

void HeartbeatSender::OnSignallingDisconnected() {

DCHECK_EQ(MessageLoop::current(), message_loop_);

- DCHECK_EQ(state_, STARTED);

- state_ = STOPPED;

- request_.reset(NULL);

+ if (state_ == STARTED) {

+ state_ = STOPPED;

+ request_.reset(NULL);

Wez 2011/07/06 22:45:15 This change means that the heart-beat request only

+ }

}

// Ignore any notifications other than signalling

« no previous file with comments | « no previous file | no next file » | no next file with comments »