Issue 7307: Reduce header dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7307: Reduce header dependencies. (Closed)

Created:
12 years, 2 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Reduce header dependencies. Random files in V8Bindings were getting rebuilt when I touched process_util.h. I tracked it down to stats_table.h and shared_memory.h. This change cuts down some dependencies there; more could be removed if we made some of our FooHandle typedefs into abstract data types instead.

Patch Set 1 #

Patch Set 2 : retry #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -28 lines)			Patch
M	base/shared_memory.h	View	6 chunks	+9 lines, -8 lines	0 comments	Download
M	base/stats_table.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	base/stats_table.cc	View	9 chunks	+38 lines, -17 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/web_contents.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

It turns out (after using a trybot) that a bunch of files were using process_util ...

12 years, 2 months ago (2008-10-22 17:28:30 UTC) #4

lgtm

Expand Messages | Collapse Messages