Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/test/automated_ui_tests/automated_ui_test_test.cc

Issue 73064: Disable flakey OpenNewBrowserWindow test. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/automated_ui_tests/automated_ui_test_base.h" 5 #include "chrome/test/automated_ui_tests/automated_ui_test_base.h"
6 #include "chrome/test/automation/browser_proxy.h" 6 #include "chrome/test/automation/browser_proxy.h"
7 #include "chrome/test/ui/ui_test.h" 7 #include "chrome/test/ui/ui_test.h"
8 8
9 TEST_F(AutomatedUITestBase, NewTab) { 9 TEST_F(AutomatedUITestBase, NewTab) {
10 int tab_count; 10 int tab_count;
(...skipping 12 matching lines...) Expand all
23 active_browser()->GetTabCount(&tab_count); 23 active_browser()->GetTabCount(&tab_count);
24 ASSERT_EQ(1, tab_count); 24 ASSERT_EQ(1, tab_count);
25 DuplicateTab(); 25 DuplicateTab();
26 active_browser()->GetTabCount(&tab_count); 26 active_browser()->GetTabCount(&tab_count);
27 ASSERT_EQ(2, tab_count); 27 ASSERT_EQ(2, tab_count);
28 DuplicateTab(); 28 DuplicateTab();
29 active_browser()->GetTabCount(&tab_count); 29 active_browser()->GetTabCount(&tab_count);
30 ASSERT_EQ(3, tab_count); 30 ASSERT_EQ(3, tab_count);
31 } 31 }
32 32
33 TEST_F(AutomatedUITestBase, OpenNewBrowserWindow) { 33 // TODO(huanr) mmoss disabled this test because it's crashing periodically on
34 // the buildbots and not giving useful debugging info.
35 TEST_F(AutomatedUITestBase, DISABLED_OpenNewBrowserWindow) {
34 int num_browser_windows; 36 int num_browser_windows;
35 int tab_count; 37 int tab_count;
36 automation()->GetBrowserWindowCount(&num_browser_windows); 38 automation()->GetBrowserWindowCount(&num_browser_windows);
37 ASSERT_EQ(1, num_browser_windows); 39 ASSERT_EQ(1, num_browser_windows);
38 scoped_ptr<BrowserProxy>browser_1(release_active_browser()); 40 scoped_ptr<BrowserProxy>browser_1(release_active_browser());
39 browser_1->GetTabCount(&tab_count); 41 browser_1->GetTabCount(&tab_count);
40 ASSERT_EQ(1, tab_count); 42 ASSERT_EQ(1, tab_count);
41 43
42 ASSERT_TRUE(OpenAndActivateNewBrowserWindow()); 44 ASSERT_TRUE(OpenAndActivateNewBrowserWindow());
43 automation()->GetBrowserWindowCount(&num_browser_windows); 45 automation()->GetBrowserWindowCount(&num_browser_windows);
(...skipping 15 matching lines...) Expand all
59 NewTab(); 61 NewTab();
60 NewTab(); 62 NewTab();
61 scoped_ptr<BrowserProxy>browser_3(release_active_browser()); 63 scoped_ptr<BrowserProxy>browser_3(release_active_browser());
62 browser_1->GetTabCount(&tab_count); 64 browser_1->GetTabCount(&tab_count);
63 ASSERT_EQ(1, tab_count); 65 ASSERT_EQ(1, tab_count);
64 browser_2->GetTabCount(&tab_count); 66 browser_2->GetTabCount(&tab_count);
65 ASSERT_EQ(2, tab_count); 67 ASSERT_EQ(2, tab_count);
66 browser_3->GetTabCount(&tab_count); 68 browser_3->GetTabCount(&tab_count);
67 ASSERT_EQ(3, tab_count); 69 ASSERT_EQ(3, tab_count);
68 } 70 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698