Made Print Preview tests autogenerated from print_preview.js.

chrome/browser/ui/webui/print_preview_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
@@ skipping 15 matching lines @@
   TestTabStripModelObserver tabstrip_observer(browser->tabstrip_model(),
                                               load_start_observer);
   TabContents* initiator_tab_contents = browser->GetSelectedTabContents();
   browser->Print();
   tabstrip_observer.WaitForObservation();
   EXPECT_NE(initiator_tab_contents, browser->GetSelectedTabContents());
 }
 
 }  // namespace
 
+// crbug.com/88104 - v8_shell#host doesn't build when host=="arm".
+#if !defined(ARCH_CPU_ARM_FAMILY)

[Lei Zhang, 2011/07/07 01:27:24]

This should be #if defined(ARCH_CPU_X86_FAMILY). I bet if we added a new
ARCH_CPU_FOO_FAMILY, it would work either. Ditto for web_ui_browsertest.cc.

[Sheridan Rawlins, 2011/07/07 04:45:33]

See crbug.com/88104 - this only doesn't compile v8_shell#host on Arm because the
flags check against target_arch instead of host_arch.  This flag was checked
with Bradley Nelson.

On 2011/07/07 01:27:24, Lei Zhang wrote:

[Lei Zhang, 2011/07/07 05:17:53]

I don't understand your reasoning. ARCH_CPU_X86_FAMILY and ARCH_CPU_ARM_FAMILY
are mutually exclusive. Defining one is the same as !defining the other.

I'm just trying to say explicitly defining the architecture this works on is
better than !defining the one (of two) architecture it doesn't work on.

[Sheridan Rawlins, 2011/07/07 07:01:55]

Will ARCH_CPU_X86_FAMILY be defined for mac?  for other non-arm platforms?  If
any new platforms are added, I'd like to try to build this the new platforms and
get this working on ARM before removing the ifndef.  This must agree with the
gyp conditions which currently check for target_arch != arm, so this ifndef
seemed reasonable and correct.

On 2011/07/07 05:17:53, Lei Zhang wrote:

[Lei Zhang, 2011/07/07 19:16:57]

Sure, let's leave it as is then. We probably won't be adding any new
architectures anytime soon anyway.
FWIW, ARCH_CPU_X86_FAMILY is defined for Mac, as they use x86 CPUs.

+
 class PrintPreviewWebUITest
     : public WebUIBrowserTest,
       public TestTabStripModelObserver::LoadStartObserver {
  protected:
   // WebUIBrowserTest:
   virtual void SetUpOnMainThread() OVERRIDE {
     WebUIBrowserTest::SetUpOnMainThread();
     if (!HasPDFLib())
       skipTest(base::StringPrintf("%s:%d: No PDF Lib.", __FILE__, __LINE__));
 
@@ skipping 19 matching lines @@
     PreLoadJavascriptLibraries(true);
   }
 
   bool HasPDFLib() const {
     FilePath pdf;
     return PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf) &&
         file_util::PathExists(pdf);
   }
 };
 
-IN_PROC_BROWSER_TEST_F(PrintPreviewWebUITest, FLAKY_TestPrintPreview) {
-  ASSERT_TRUE(RunJavascriptTest("testPrintPreview",
-                                *Value::CreateBooleanValue(HasPDFLib())));
-}
+#include "chrome/test/data/webui/print_preview-inl.h"

[Lei Zhang, 2011/07/07 01:27:24]

This is the dynamically generated test list?

[Sheridan Rawlins, 2011/07/07 04:45:33]

Yes.  The test is generated from any functions in |this| after importing the
chrome/test/data/webui/print_preview.js

[Lei Zhang, 2011/07/07 05:17:53]

Then it should go into out/{Release,Debug} or it's Win/Mac equivalent. We don't
write into source directories.

[Sheridan Rawlins, 2011/07/07 07:01:55]

It does go there.  Please see
http://codereview.chromium.org/7087014/diff/75002/chrome/chrome_tests.gypi for
more information on the magic which puts it there and adds it to the include
path.  Also, this is not "out" but "ninja" when building with ninja :)
Basically, it's the '<(SHARED_INTERMEDIATE_DIR)/js2webui'.

On 2011/07/07 05:17:53, Lei Zhang wrote:

[Lei Zhang, 2011/07/07 19:16:57]

Let's just make the #include obvious that it's a generated directory and not the
source directory.

[Sheridan Rawlins, 2011/07/07 20:30:54]

Done.

+
+#endif  // !defined(ARCH_CPU_ARM_FAMILY)