Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: content/common/sandbox_mac_unittest_helper.mm

Issue 7304008: Ensure tests check the return of SpawnChild() when they may wait without timeouts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mac compile fixes Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/sandbox_mac_diraccess_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_mac_unittest_helper.mm
diff --git a/content/common/sandbox_mac_unittest_helper.mm b/content/common/sandbox_mac_unittest_helper.mm
index 564cc8b08556ed4476d7ea2cf3e859d112d242ee..3b0345d05d80171a6c5ad6d7b1f637f010610bd6 100644
--- a/content/common/sandbox_mac_unittest_helper.mm
+++ b/content/common/sandbox_mac_unittest_helper.mm
@@ -81,6 +81,10 @@ bool MacSandboxTest::RunTestInSandbox(Sandbox::SandboxProcessType sandbox_type,
base::ProcessHandle child_process = SpawnChild("mac_sandbox_test_runner",
false);
+ if (child_process == base::kNullProcessHandle) {
+ LOG(WARNING) << "SpawnChild failed";
+ return false;
+ }
int code = -1;
if (!base::WaitForExitCode(child_process, &code)) {
LOG(WARNING) << "base::WaitForExitCode failed";
« no previous file with comments | « content/common/sandbox_mac_diraccess_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698