Issue 7304005: Gets BackingStoreSkia to work on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7304005: Gets BackingStoreSkia to work on windows. (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gets BackingStoreSkia to work on windows. BUG=none TEST=none R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91454

Patch Set 2 : nuke ifdefs #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/browser/renderer_host/backing_store_skia.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/7304005/diff/1/content/browser/renderer_host/backing_store_skia.cc File content/browser/renderer_host/backing_store_skia.cc (right): http://codereview.chromium.org/7304005/diff/1/content/browser/renderer_host/backing_store_skia.cc#newcode65 content/browser/renderer_host/backing_store_skia.cc:65: // Creating a platform canvas on windows results in ...

9 years, 5 months ago (2011-07-01 22:26:21 UTC) #2

sky

On Fri, Jul 1, 2011 at 3:26 PM, <brettw@chromium.org> wrote: > > http://codereview.chromium.org/7304005/diff/1/content/browser/renderer_host/backing_store_skia.cc > File ...

9 years, 5 months ago (2011-07-01 23:05:34 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 7304005: Gets BackingStoreSkia to work on windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nuke ifdefs #

Messages