Issue 73027: Added new V8 files to v8.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73027: Added new V8 files to v8.gyp (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added new V8 files to v8.gyp. TBR=yurys@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13647

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/temp_gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

11 years, 8 months ago (2009-04-14 05:16:54 UTC) #2

LGTM

http://codereview.chromium.org/73027/diff/1/2
File build/temp_gyp/v8.gyp (right):

http://codereview.chromium.org/73027/diff/1/2#newcode95
Line 95: '../../v8/src/func-name-inferrer.cc',
is there a reason to shift these two lines?

Expand Messages | Collapse Messages