Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Side by Side Diff: src/frames-ia32.cc

Issue 73020: Implemented "no heap access" mode for JSFrame which is used for stack sampling in profiler. (Closed)
Patch Set: Renamings as Soeren suggested Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 } 71 }
72 72
73 73
74 int JavaScriptFrame::GetProvidedParametersCount() const { 74 int JavaScriptFrame::GetProvidedParametersCount() const {
75 return ComputeParametersCount(); 75 return ComputeParametersCount();
76 } 76 }
77 77
78 78
79 Address JavaScriptFrame::GetCallerStackPointer() const { 79 Address JavaScriptFrame::GetCallerStackPointer() const {
80 int arguments; 80 int arguments;
81 if (Heap::gc_state() != Heap::NOT_IN_GC) { 81 if (Heap::gc_state() != Heap::NOT_IN_GC || disable_heap_access_) {
82 // The arguments for cooked frames are traversed as if they were 82 // The arguments for cooked frames are traversed as if they were
83 // expression stack elements of the calling frame. The reason for 83 // expression stack elements of the calling frame. The reason for
84 // this rather strange decision is that we cannot access the 84 // this rather strange decision is that we cannot access the
85 // function during mark-compact GCs when the stack is cooked. 85 // function during mark-compact GCs when the stack is cooked.
86 // In fact accessing heap objects (like function->shared() below) 86 // In fact accessing heap objects (like function->shared() below)
87 // at all during GC is problematic. 87 // at all during GC is problematic.
88 arguments = 0; 88 arguments = 0;
89 } else { 89 } else {
90 // Compute the number of arguments by getting the number of formal 90 // Compute the number of arguments by getting the number of formal
91 // parameters of the function. We must remember to take the 91 // parameters of the function. We must remember to take the
(...skipping 14 matching lines...) Expand all
106 106
107 107
108 Address InternalFrame::GetCallerStackPointer() const { 108 Address InternalFrame::GetCallerStackPointer() const {
109 // Internal frames have no arguments. The stack pointer of the 109 // Internal frames have no arguments. The stack pointer of the
110 // caller is at a fixed offset from the frame pointer. 110 // caller is at a fixed offset from the frame pointer.
111 return fp() + StandardFrameConstants::kCallerSPOffset; 111 return fp() + StandardFrameConstants::kCallerSPOffset;
112 } 112 }
113 113
114 114
115 } } // namespace v8::internal 115 } } // namespace v8::internal
OLDNEW
« src/frames.h ('K') | « src/frames-arm.cc ('k') | src/frames-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698