Issue 7301010: Fixed improper destruction of transfer buffers that are still in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7301010: Fixed improper destruction of transfer buffers that are still in use. (Closed)

Created:
9 years, 5 months ago by jbates

Modified:
9 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit), greggman, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, Vangelis Kokkevis, Zhenyao Mo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

We were synchronously destroying the RendererGlContext transfer buffers while commands may still be pending in the command buffer that use them. This generated spurious kOutOfBounds errors. kOutOfBounds errors cause us to kill the associated GpuChannel. That leads to lots of bad behavior, such as failing to reload certain WebGL demos. This change simply lets the command buffer destroy the shared memory in its destructor instead of destroying them explicitly. The GPU-side resources are cleaned up when the command buffer is destroyed. BUG=88115 TEST=Open NVIDIA Command Buffer Object WebGL demo; Refresh; Verify successful refresh. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91747

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -21 lines)			Patch
	M	content/renderer/gpu/renderer_gl_context.cc	View		4 chunks	+18 lines, -20 lines	0 comments	Download
	M	gpu/command_buffer/common/constants.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM. Sorry I missed this.

Expand Messages | Collapse Messages