Issue 7301009: Removed unnecessary call to initialize the COM library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7301009: Removed unnecessary call to initialize the COM library (Closed)

Created:
9 years, 5 months ago by ramant (doing other things)

Modified:
9 years, 5 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Removed unnecessary call to initialize the COM library to fix the crash because CoInitialize() call failed. BUG=85589 TEST=thread_watcher unit tests R=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91714

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	chrome/browser/metrics/thread_watcher.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/metrics/thread_watcher.cc	View	1	2 chunks	+0 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

ramant (doing other things)

Hi willchan, WatchDog thread doesn't seem to require initialization of the COM library. We had ...

9 years, 5 months ago (2011-07-05 18:59:06 UTC) #1

willchan no longer on Chromium

Sure, fine with me, but please just delete all those #ifdef'd code blocks rather than ...

9 years, 5 months ago (2011-07-05 19:03:15 UTC) #2

ramant (doing other things)

9 years, 5 months ago (2011-07-05 22:13:19 UTC) #3

Hi willchan,
  Deleted the commented out code.

thanks,
raman