Issue 7300019: Trigger a reset of force-compositing-mode in about:flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7300019: Trigger a reset of force-compositing-mode in about:flags. (Closed)

Created:
9 years, 5 months ago by jbates

Modified:
9 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, darin (slow to review), Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Trigger a reset of force-compositing-mode in about:flags. We've been getting various complaints and bug reports by users that don't realize force-compositing-mode is enabled. This change should cause the about:flags option to reset without changing the command-line flag or any text that users see. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91396

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/about_flags.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/7300019/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/7300019/diff/1/chrome/browser/about_flags.cc#newcode144 chrome/browser/about_flags.cc:144: "force-compositing-mode*", hm, maybe some less magical character? "2"?

9 years, 5 months ago (2011-07-02 00:15:26 UTC) #2

jbates

sure :) http://codereview.chromium.org/7300019/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/7300019/diff/1/chrome/browser/about_flags.cc#newcode144 chrome/browser/about_flags.cc:144: "force-compositing-mode*", On 2011/07/02 00:15:26, Nico wrote: > ...

9 years, 5 months ago (2011-07-02 00:20:52 UTC) #3

LGTM

Expand Messages | Collapse Messages