Changes header value sent for instant from 'preview' to 'instant'. I'm

Changes header value sent for instant from 'preview' to 'instant'. I'm
doing this as having it use the same value as Safari results in too
much badness.

BUG=87102
TEST=none
R=darin@chromium.org,tonyg@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91560

[darin (slow to review), 2011-07-01 23:16:47]

LGTM

(I am still interested in ways that we could possibly avoid this header in
the first place.)

On Fri, Jul 1, 2011 at 4:15 PM, <sky@chromium.org> wrote:

> Reviewers: darin, tonyg,
>
> Description:
> Changes header value sent for instant from 'preview' to 'instant'. I'm
> doing this as having it use the same value as Safari results in too
> much badness.
>
> BUG=87102
> TEST=none
> R=darin@chromium.org,tonyg@**chromium.org <tonyg@chromium.org>
>
>
> Please review this at
http://codereview.chromium.**org/7300016/<http://codereview.chromium.org/7300...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/instant/**instant_loader.cc
>
>
> Index: chrome/browser/instant/**instant_loader.cc
> diff --git a/chrome/browser/instant/**instant_loader.cc
> b/chrome/browser/instant/**instant_loader.cc
> index 00d86542d95c0b790720e93824028c**12adfec4f5..**
> 0e7fc35cd7f13110f4739ccf5bfbcf**9010dc260c 100644
> --- a/chrome/browser/instant/**instant_loader.cc
> +++ b/chrome/browser/instant/**instant_loader.cc
> @@ -61,7 +61,7 @@ const int kHostBlacklistStatusCode = 403;
>
>  // Header and value set for all loads.
>  const char kPreviewHeader[] = "X-Purpose";
> -const char kPreviewHeaderValue[] = "preview";
> +const char kPreviewHeaderValue[] = "instant";
>
>  }  // namespace
>
>
>
>

[sky, 2011-07-01 23:17:43]

I'm nervous about removing it entirely.

  -Scott

On Fri, Jul 1, 2011 at 4:16 PM, Darin Fisher <darin@chromium.org> wrote:
> LGTM
> (I am still interested in ways that we could possibly avoid this header in
> the first place.)
>
> On Fri, Jul 1, 2011 at 4:15 PM, <sky@chromium.org> wrote:
>>
>> Reviewers: darin, tonyg,
>>
>> Description:
>> Changes header value sent for instant from 'preview' to 'instant'. I'm
>> doing this as having it use the same value as Safari results in too
>> much badness.
>>
>> BUG=87102
>> TEST=none
>> R=darin@chromium.org,tonyg@chromium.org
>>
>>
>> Please review this at http://codereview.chromium.org/7300016/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M chrome/browser/instant/instant_loader.cc
>>
>>
>> Index: chrome/browser/instant/instant_loader.cc
>> diff --git a/chrome/browser/instant/instant_loader.cc
>> b/chrome/browser/instant/instant_loader.cc
>> index
>>
00d86542d95c0b790720e93824028c12adfec4f5..0e7fc35cd7f13110f4739ccf5bfbcf9010dc260c
>> 100644
>> --- a/chrome/browser/instant/instant_loader.cc
>> +++ b/chrome/browser/instant/instant_loader.cc
>> @@ -61,7 +61,7 @@ const int kHostBlacklistStatusCode = 403;
>>
>>  // Header and value set for all loads.
>>  const char kPreviewHeader[] = "X-Purpose";
>> -const char kPreviewHeaderValue[] = "preview";
>> +const char kPreviewHeaderValue[] = "instant";
>>
>>  }  // namespace
>>
>>
>>
>
>