Consolidate data storage and notifications in the cloud policy subsystem

chrome/browser/policy/user_policy_token_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_USER_POLICY_TOKEN_CACHE_H_
 #define CHROME_BROWSER_POLICY_USER_POLICY_TOKEN_CACHE_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"

[Joao da Silva, 2011/07/06 16:45:14]

Nit: weak_ptr.h not used

[gfeher, 2011/07/07 13:51:00]

Now that you mention, I actually reintroduce using it! :-)

+#include "chrome/browser/policy/cloud_policy_data.h"
 #include "chrome/browser/policy/proto/device_management_local.pb.h"

[Joao da Silva, 2011/07/06 16:45:14]

Nit: move device_management_local.pb.h to .cc

[gfeher, 2011/07/07 13:51:00]

Done.

 
 namespace policy {
 
 // Responsible for managing the on-disk token cache.
 class UserPolicyTokenCache
-    : public base::RefCountedThreadSafe<UserPolicyTokenCache> {
+    : public base::RefCountedThreadSafe<UserPolicyTokenCache>,
+      public CloudPolicyData::Observer {
  public:
-  // Callback interface for reporting a successfull load.
-  class Delegate {
-   public:
-    virtual ~Delegate();
-    virtual void OnTokenCacheLoaded(const std::string& token,
-                                    const std::string& device_id) = 0;
-  };
-
-  UserPolicyTokenCache(const base::WeakPtr<Delegate>& delegate,
+  UserPolicyTokenCache(CloudPolicyData* data,
                        const FilePath& cache_file);
 
   // Starts loading the disk cache. After the load is finished, the result is
   // reported through the delegate.
   void Load();
 
   // Stores credentials asynchronously to disk.
   void Store(const std::string& token, const std::string& device_id);
 
+  // CloudPolicyData::Observer implementation:
+  virtual void OnDeviceTokenChanged() OVERRIDE;
+  virtual void OnCredentialsChanged() OVERRIDE;
+  virtual void OnPolicyDataGoingAway() OVERRIDE;
+
  private:
   friend class base::RefCountedThreadSafe<UserPolicyTokenCache>;
-  ~UserPolicyTokenCache();
+  virtual ~UserPolicyTokenCache();
 
   void LoadOnFileThread();
   void NotifyOnUIThread(const std::string& token,
                         const std::string& device_id);
   void StoreOnFileThread(const std::string& token,
                          const std::string& device_id);
 
-  const base::WeakPtr<Delegate> delegate_;
+  CloudPolicyData* data_;
   const FilePath cache_file_;
 
   DISALLOW_COPY_AND_ASSIGN(UserPolicyTokenCache);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_USER_POLICY_TOKEN_CACHE_H_