Issue 7298009: Labels don't need to respond to mouse clicks and doing so can interfere with button clicks, for e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7298009: Labels don't need to respond to mouse clicks and doing so can interfere with button clicks, for e... (Closed)

Created:
9 years, 5 months ago by Finnur

Modified:
9 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Labels don't need to respond to mouse clicks and doing so can interfere with button clicks, for example if the label width extends over a button (in some cases invisibly). BUG=87439 TEST=None. The problem that prompted this has been fixed by Scott, but similar problems might occur in the future so I think it is good to fix the underlying problem as well (since the symptoms are so weird: half a button non-clickable). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91421

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	views/controls/label.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	views/controls/label.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages