Issue 7298004: Do a backing store sparseness check on fast element delete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7298004: Do a backing store sparseness check on fast element delete. (Closed)

Created:
9 years, 5 months ago by Vitaly Repeshko

Modified:
9 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Do a backing store sparseness check on fast element delete. R=vegorov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8516

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
	M	src/objects.cc	View		1 chunk	+23 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/7298004/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7298004/diff/1/src/objects.cc#newcode3052 src/objects.cc:3052: if (backing_store->get(i) != hole) ++num_used; You can have ...

9 years, 5 months ago (2011-07-01 12:25:58 UTC) #2

Vitaly Repeshko

9 years, 5 months ago (2011-07-01 13:05:02 UTC) #3

Thanks!

http://codereview.chromium.org/7298004/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7298004/diff/1/src/objects.cc#newcode3052
src/objects.cc:3052: if (backing_store->get(i) != hole) ++num_used;
On 2011/07/01 12:25:58, Vyacheslav Egorov wrote:
> You can have an early exit from the loop if num_used * 4 becomes bigger then
> length.
> 
> This will optimize some common cases.

Good idea. Done.

Expand Messages | Collapse Messages