chrome/browser/automation/testing_automation_provider.cc - Issue 7294013: Modified cancel and interrupt processing to avoid race with history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 7294013: Modified cancel and interrupt processing to avoid race with history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed various problems surfaced by trybots. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index f29dc9441531866b8bcde8f23c0b93887f4a729a..b1cec057e9e7c9e4badc1be0203889038742bf2c 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -2992,7 +2992,7 @@ void TestingAutomationProvider::PerformActionOnDownload(

} else if (action == "cancel") {

selected_item->AddObserver(new AutomationProviderDownloadUpdatedObserver(

this, reply_message, false));

- selected_item->Cancel(true);

+ selected_item->Cancel();

} else {

AutomationJSONReply(this, reply_message)

.SendError(StringPrintf("Invalid action '%s' given.", action.c_str()));