chrome/browser/automation/automation_provider_observers.cc - Issue 7294013: Modified cancel and interrupt processing to avoid race with history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 7294013: Modified cancel and interrupt processing to avoid race with history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed various problems surfaced by trybots. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_provider_observers.cc

diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc

index 95b103d4e07d08014c861c13ccf8b888cecbde02..8024134ca438aac81d9cff1d5e7a72b5c5befc53 100644

--- a/chrome/browser/automation/automation_provider_observers.cc

+++ b/chrome/browser/automation/automation_provider_observers.cc

@@ -1461,7 +1461,7 @@ void AutomationProviderDownloadItemObserver::OnDownloadUpdated(

// download is cancelled.

if (interrupted_) {

// |Cancel()| does nothing if |download| is already interrupted.

- download->Cancel(true);

+ download->Cancel();

RemoveAndCleanupOnLastEntry(download);

}