chrome/browser/ui/cocoa/download/download_item_controller.mm - Issue 7294013: Modified cancel and interrupt processing to avoid race with history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 7294013: Modified cancel and interrupt processing to avoid race with history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged to TOT. Again :-}. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/download/download_item_controller.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm

index 60b037c70f19d8d882ca66029ad1c4eb4f91fb88..3a84549ad5d672ba9571ad172e34d71160f5d887 100644

--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm

@@ -351,7 +351,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {

base::Time::Now() - creationTime_);

DownloadItem* download = bridge_->download_model()->download();

if (download->IsPartialDownload())

- download->Cancel(true);

+ download->Cancel();

download->Delete(DownloadItem::DELETE_DUE_TO_USER_DISCARD);

// WARNING: we are deleted at this point. Don't access 'this'.

}