chrome/browser/download/download_history.h - Issue 7294013: Modified cancel and interrupt processing to avoid race with history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_history.h

Issue 7294013: Modified cancel and interrupt processing to avoid race with history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged to TOT. Again :-}. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_history.h

diff --git a/chrome/browser/download/download_history.h b/chrome/browser/download/download_history.h

index f4b48812137e7d34848e623cb39fb957f81e3e1d..44bdf60d2c6de2751962277af7533d3d1d65118b 100644

--- a/chrome/browser/download/download_history.h

+++ b/chrome/browser/download/download_history.h

@@ -51,8 +51,10 @@ class DownloadHistory {

void UpdateDownloadPath(DownloadItem* download_item,

const FilePath& new_path);

- // Removes |download_item| from the history database.

- void RemoveEntry(DownloadItem* download_item);

+ // Removes the download identified by |db_handle| from the history database.

+ // |db_handle| is used instead of the DownloadItem pointer to allow

+ // removal after deletion of the download item.

+ void RemoveEntry(int64 db_handle);

// Removes download-related history entries in the given time range.

void RemoveEntriesBetween(const base::Time remove_begin,