chrome/browser/ui/gtk/download/download_item_gtk.cc - Issue 7294013: Modified cancel and interrupt processing to avoid race with history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.cc

Issue 7294013: Modified cancel and interrupt processing to avoid race with history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments, fixed some stuff from try jobs. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/download/download_item_gtk.cc

diff --git a/chrome/browser/ui/gtk/download/download_item_gtk.cc b/chrome/browser/ui/gtk/download/download_item_gtk.cc

index e189c931ab37dde39ad971ec5efdfd75e658283e..fbb273cd939867d60aee02ccfb800eeabe91a91c 100644

--- a/chrome/browser/ui/gtk/download/download_item_gtk.cc

+++ b/chrome/browser/ui/gtk/download/download_item_gtk.cc

@@ -867,6 +867,6 @@ void DownloadItemGtk::OnDangerousDecline(GtkWidget* button) {

UMA_HISTOGRAM_LONG_TIMES("clickjacking.discard_download",

base::Time::Now() - creation_time_);

if (get_download()->IsPartialDownload())

- get_download()->Cancel(true);

+ get_download()->Cancel();

get_download()->Delete(DownloadItem::DELETE_DUE_TO_USER_DISCARD);

}