Issue 7294006: Try to bandaid leaks due to TabContentsWrapper not force-closing all InfoBarDelegates on shutdown...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7294006: Try to bandaid leaks due to TabContentsWrapper not force-closing all InfoBarDelegates on shutdown... (Closed)

Created:
9 years, 5 months ago by Peter Kasting

Modified:
9 years, 5 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Alexander Potapenko, Paweł Hajdan Jr., Timur Iskhodzhanov, Avi (use Gerrit), pam+watch_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Try to bandaid leaks due to TabContentsWrapper not force-closing all InfoBarDelegates on shutdown. The real fix will come when changing to the newer ownership model, when TCW can CloseSoon() Infobars directly, but for now, manually close things in a couple places. Also makes a few other tiny changes to bring the code yet closer to my final-form checkout. BUG=87998 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91316

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -60 lines)			Patch
M	chrome/browser/download/download_request_infobar_delegate_unittest.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc	View	1	13 chunks	+30 lines, -15 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_container.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages