Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 7292033: First pass at freezing stable pepper interfaces to 1.0. (Closed)

Created:
9 years, 5 months ago by dmichael (off chromium)
Modified:
9 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

First pass at revving stable pepper interfaces to 1.0. Missing PPB_Core (pending removal of MemAlloc/MemFree) and new input event interfaces, in case we want to change them in the next ~week. BUG=84519 TEST=ppapi tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92302

Patch Set 1 : fix unittests #

Patch Set 2 : merge #

Patch Set 3 : Take PPP_Instance 1.0 out, so we can take HandleInputEvent out for 1.0 #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -41 lines) Patch
M ppapi/c/ppb_audio.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_audio_config.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_file_io.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_file_ref.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_file_system.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_image_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_instance.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/c/ppb_messaging.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_loader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_request_info.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_response_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_var.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppp_messaging.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_thunk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/thunk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 5 chunks +50 lines, -16 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Not as bad as it looks; most of the files are just updating the interface ...
9 years, 5 months ago (2011-07-09 05:05:41 UTC) #1
brettw
LGTM, but please coordinate with Noel for landing this since he's trying to land his ...
9 years, 5 months ago (2011-07-11 18:01:08 UTC) #2
dmichael (off chromium)
I uploaded a new version with the rev of PPP_Instance taken out, if you care ...
9 years, 5 months ago (2011-07-12 20:53:08 UTC) #3
brettw
9 years, 5 months ago (2011-07-12 21:03:12 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698