Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 7292030: When compiling C++, CXXFLAGS *and* CCFLAGS are used, so there is no need to pass (Closed)

Created:
9 years, 5 months ago by Sven Panne
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

When compiling C++, CXXFLAGS *and* CCFLAGS are used, so there is no need to pass the latter ones twice. Committed: http://code.google.com/p/v8/source/detail?r=8505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M SConstruct View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 5 months ago (2011-07-01 08:53:55 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 5 months ago (2011-07-01 08:59:04 UTC) #2
Rico
9 years, 5 months ago (2011-07-01 09:02:07 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698