Issue 7292028: Revert 91270 - sbox_unittests HandleTable.FindTable failing on Win XP & Vista

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7292028: Revert 91270 - sbox_unittests HandleTable.FindTable failing on Win XP & Vista (Closed)

Created:
9 years, 5 months ago by Ryan Sleevi

Modified:
9 years, 5 months ago

Reviewers:
jschuh

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 91270 - sbox_unittests HandleTable.FindTable failing on Win XP & Vista Had a bug in the handle table unit test. Added GetHandleName to fix the bug and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* Review URL: http://codereview.chromium.org/7218066 TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91271

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -32 lines)			Patch
M	sandbox/src/handle_table.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sandbox/src/handle_table.cc	View	4 chunks	+13 lines, -25 lines	0 comments	Download
M	sandbox/src/handle_table_unittest.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Sample logs from Vista Tests (1) and Vista Tests (dbg)(3) http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%28dbg%29%283%29/builds/12008/steps/sbox_unittests/logs/stdio http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%281%29/builds/6569/steps/sbox_unittests/logs/stdio [ RUN ] ...

9 years, 5 months ago (2011-07-01 05:40:31 UTC) #2

Ryan Sleevi

9 years, 5 months ago (2011-07-01 06:03:34 UTC) #3

Sorry, slight mistake in the revert text - It was only Vista failing - I
misidentified the hovertext for the XP bots; they passed fine.

Expand Messages | Collapse Messages