Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tests/ppapi_test_example/ppapi_test_example.cc

Issue 7292002: Remove plugin connection to PPAPI scriptable objects (var deprecated). Also (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/ppapi_test_example/ppapi_test_example.cc
===================================================================
--- tests/ppapi_test_example/ppapi_test_example.cc (revision 5984)
+++ tests/ppapi_test_example/ppapi_test_example.cc (working copy)
@@ -19,19 +19,6 @@
printf("--- Callback\n");
}
-// Below are the before & after versions of sample test cases demonstrating
-// how to transition from synchronous scripting to postMessage as the test
-// driving mechanism.
-
-// Before.
-PP_Var TestSimpleSync() {
- printf("--- TestSimpleSync\n");
- EXPECT(pp_instance() != kInvalidInstance);
- EXPECT(pp_module() != kInvalidModule);
- return TEST_PASSED;
-}
-
-// After.
void TestSimpleAsync() {
polina 2011/07/12 08:58:01 Please drop Async postfixes now.
sehr (please use chromium) 2011/07/12 16:44:23 Done.
printf("--- TestSimpleAsync\n");
EXPECT_ASYNC(pp_instance() != kInvalidInstance);
@@ -39,16 +26,6 @@
TEST_PASSED_ASYNC;
}
-// Before.
-PP_Var TestCallbackSync() {
- printf("--- TestCallbackSync\n");
- PP_CompletionCallback callback = MakeTestableCompletionCallback(
- "CallbackSync", Callback, NULL /*user_data*/);
- PPBCore()->CallOnMainThread(10, callback, PP_OK);
- return TEST_PASSED;
-}
-
-// After.
void TestCallbackAsync() {
printf("--- TestCallbackAsync\n");
PP_CompletionCallback callback = MakeTestableCompletionCallback(
@@ -60,10 +37,6 @@
} // namespace
void SetupTests() {
- // Before.
- RegisterScriptableTest("TestSimpleSync", TestSimpleSync);
- RegisterScriptableTest("TestCallbackSync", TestCallbackSync);
- // After.
RegisterTest("TestSimpleAsync", TestSimpleAsync);
RegisterTest("TestCallbackAsync", TestCallbackAsync);
}

Powered by Google App Engine
This is Rietveld 408576698