Make date parser handle all ES5 Date Time Strings correctly.

Make date parser handle all ES5 Date Time Strings correctly.

This means that ES5 Date Time Strings will default to UTC if timezone is absent.
Handle as many legacy strings as possible the same way as before

BUG=v8:1498
TEST=mjsunit/date

Committed: http://code.google.com/p/v8/source/detail?r=8513

[Erik Corry, 2011-07-01 10:22:46]

LGTM

Please be sure to check performance and non-V8 test suites before committing.

http://codereview.chromium.org/7291022/diff/1/src/dateparser-inl.h
File src/dateparser-inl.h (right):

http://codereview.chromium.org/7291022/diff/1/src/dateparser-inl.h#newcode180
src/dateparser-inl.h:180: 
Blank line.

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h
File src/dateparser.h (right):

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode240
src/dateparser.h:240: kInvalidTokenTag = -5,
These are deliberately the same?

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode370
src/dateparser.h:370: return index_ < kSize ? (comp_[index_++] = n, true) :
false;
Holy moley!

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode378
src/dateparser.h:378: 
Blank line above private: rather than below it.

http://codereview.chromium.org/7291022/diff/1/test/mjsunit/date.js
File test/mjsunit/date.js (right):

http://codereview.chromium.org/7291022/diff/1/test/mjsunit/date.js#newcode272
test/mjsunit/date.js:272: assertEquals(68338203500,
Date.parse("+001972-03T23:50:03.500+01:00"));
I'm not seeing any negative non-zero time zones or any time zones that are not a
whole number of hours in these tests.

[Lasse Reichstein, 2011-07-01 10:49:52]

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h
File src/dateparser.h (right):

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode240
src/dateparser.h:240: kInvalidTokenTag = -5,
No. Fixed.

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode370
src/dateparser.h:370: return index_ < kSize ? (comp_[index_++] = n, true) :
false;
Indeed, rewritten.

http://codereview.chromium.org/7291022/diff/1/src/dateparser.h#newcode378
src/dateparser.h:378: 
On 2011/07/01 10:22:46, Erik Corry wrote:
> Blank line above private: rather than below it.

Done.

http://codereview.chromium.org/7291022/diff/1/test/mjsunit/date.js
File test/mjsunit/date.js (right):

http://codereview.chromium.org/7291022/diff/1/test/mjsunit/date.js#newcode272
test/mjsunit/date.js:272: assertEquals(68338203500,
Date.parse("+001972-03T23:50:03.500+01:00"));
Adding more time-zone based tests.