Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 7291012: Mmm, pie (Closed)

Created:
9 years, 5 months ago by Mark Mentovai
Modified:
9 years, 5 months ago
Reviewers:
TVL, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Mmm, pie. Enable position independence by linking executables with the -pie linker flag. This was previously done in r29592, but had to be backed out in r29604 because Valgrind didn't understand slide. I don't know if Valgrind understands slide or not on Mac OS X now, but for the time being, we'll do this in non-Valgrind build configurations. Position independence turns on address space layout randomization (ASLR). No perf impact expected. We don't really have any significant quantity of exported symbols for the loader to chew on. BUG=16713 TEST=Everything should still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91243

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
9 years, 5 months ago (2011-06-30 20:08:24 UTC) #1
Mark Mentovai
TVL isn’t here. Let’s try Nico.
9 years, 5 months ago (2011-06-30 20:22:23 UTC) #2
Nico
I read the bug, but didn't see any notes on the perf impact of this ...
9 years, 5 months ago (2011-06-30 20:35:27 UTC) #3
Mark Mentovai
ASLR. I’ll update.
9 years, 5 months ago (2011-06-30 20:36:15 UTC) #4
Nico
9 years, 5 months ago (2011-06-30 21:59:44 UTC) #5
LGTM with "no perf impact" in cl description.

Powered by Google App Engine
This is Rietveld 408576698