Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 7291010: Change MessagePumpLibevent::Run to process I/O events before doing idle (Closed)

Created:
9 years, 5 months ago by wtc
Modified:
9 years, 5 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Change MessagePumpLibevent::Run to process I/O events before doing idle work. R=jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91252

Patch Set 1 #

Patch Set 2 : Need to report 'did work' when being woken up by the internal pipe #

Total comments: 1

Patch Set 3 : Update comment, set processed_io_events_ in OnLibeventNotification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/message_pump_libevent.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M base/message_pump_libevent.cc View 1 2 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
This is the CL that you reviewed in http://codereview.chromium.org/7262011/ It was reverted because it broke ...
9 years, 5 months ago (2011-06-30 21:51:20 UTC) #1
Mark Mentovai
LGTM http://codereview.chromium.org/7291010/diff/4001/base/message_pump_libevent.cc File base/message_pump_libevent.cc (right): http://codereview.chromium.org/7291010/diff/4001/base/message_pump_libevent.cc#newcode233 base/message_pump_libevent.cc:233: if (!keep_running_) I was wondering about this. I ...
9 years, 5 months ago (2011-06-30 22:07:16 UTC) #2
rvargas (doing something else)
LGTM
9 years, 5 months ago (2011-06-30 22:11:38 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-07-01 01:55:31 UTC) #4
Change committed as 91252

Powered by Google App Engine
This is Rietveld 408576698