chrome/browser/resources/new_tab.html - Issue 7291004: Wire up notifications to the New Tab page.

Side by Side Diff: chrome/browser/resources/new_tab.html

Issue 7291004: Wire up notifications to the New Tab page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="	2 <html i18n-values="

3 dir:textdirection;	3 dir:textdirection;

4 bookmarkbarattached:bookmarkbarattached;	4 bookmarkbarattached:bookmarkbarattached;

5 hasattribution:hasattribution;	5 hasattribution:hasattribution;

6 anim:anim;	6 anim:anim;

7 syncispresent:syncispresent;	7 syncispresent:syncispresent;

8 customlogo:customlogo"	8 customlogo:customlogo"

9 install-animation-enabled="true">	9 install-animation-enabled="true">

10 <head>	10 <head>

(...skipping 133 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
144 <span id="login-username"></span>	144 <span id="login-username"></span>

145 </div>	145 </div>

146	146

147 <div class="maxiview" id="apps-maxiview">	147 <div class="maxiview" id="apps-maxiview">

148 <div id="apps-promo">	148 <div id="apps-promo">

149 <p id="apps-promo-heading"></p>	149 <p id="apps-promo-heading"></p>

150 <a class="g-button-basic" id="apps-promo-link" href=""></a><br>	150 <a class="g-button-basic" id="apps-promo-link" href=""></a><br>

151 <button id="apps-promo-hide"></button>	151 <button id="apps-promo-hide"></button>

152 </div>	152 </div>

153 <div id="apps-content"></div>	153 <div id="apps-content"></div>

	154 <div id="notification_bubble" class="notification_bubble">

	155 <img id="notification_close" src="chrome://theme/IDR_CLOSE_BAR"

	156 class="app_notification_close" />
	Evan Stade 2011/06/30 23:20:33 indent is 5, should be 4. Don't need / before >. C indent is 5, should be 4. Don't need / before >. Classes and IDs should use hyphens rather than underscores. Finnur 2011/07/01 00:33:55 Done. Show quoted text On 2011/06/30 23:20:33, Evan Stade wrote: > indent is 5, should be 4. Don't need / before >. Classes and IDs should use > hyphens rather than underscores. Done.
	157 <strong id="notification_title">Title</strong><br>
	Evan Stade 2011/06/30 23:20:33 Do you really want this text content? Do you really want this text content? Finnur 2011/07/01 00:33:55 Done. Show quoted text On 2011/06/30 23:20:33, Evan Stade wrote: > Do you really want this text content? Done.
	158 <span id="notification_message">Message</span><br><br>

	159 <a class="notification_link" id="notification_link">Link</a></div>

	160 <div id="arrow_contents" class="arrow arrow_contents"></div>

	161 <div id="arrow_border" class="arrow arrow_border"></div>
	Evan Stade 2011/06/30 23:20:33 I can't really say without seeing the final produc I can't really say without seeing the final product, but it seems like there should only be a single arrow div, and its appearance (border, shadow, etc.) should be controlled with css Finnur 2011/07/01 00:33:55 See screenshot in bug. In principal, I agree and See screenshot in bug. In principal, I agree and I tried but I can't find any way to create a single div that's triangular in shape and have borders and shadows work properly (borders and shadows appear rectangular). In fact, this is the way people recommend you do it because it is hard (impossible?) otherwise. If you have tricks up your sleeve, I'd be willing to consider them for a future changelist (I'm running out of time due to vacation that is coming up). :) On 2011/06/30 23:20:33, Evan Stade wrote: Show quoted text > I can't really say without seeing the final product, but it seems like there > should only be a single arrow div, and its appearance (border, shadow, etc.) > should be controlled with css
	162 <div id="arrow_shadow" class="arrow arrow_shadow"></div>
	Evan Stade 2011/06/30 23:20:33 why do you have arrow_shadow as both an id and cla why do you have arrow_shadow as both an id and class? Finnur 2011/07/01 00:33:55 The class is for .css referencing and the id is to Show quoted text On 2011/06/30 23:20:33, Evan Stade wrote: > why do you have arrow_shadow as both an id and class? The class is for .css referencing and the id is to be able to do GetElementById('arrow_border'). GetElementByClassName('arrow_border') doesn't work, probably because the classes are 'arrow arrow_border' not 'arrow_border', and relying on the class names and their order not changing seems brittle. Evan Stade 2011/07/02 00:27:50 you can reference an item by ID in css Show quoted text On 2011/07/01 00:33:55, Finnur wrote: > On 2011/06/30 23:20:33, Evan Stade wrote: > > why do you have arrow_shadow as both an id and class? > > The class is for .css referencing and the id is to be able to do > GetElementById('arrow_border'). > > GetElementByClassName('arrow_border') doesn't work, probably because the classes > are 'arrow arrow_border' not 'arrow_border', and relying on the class names and > their order not changing seems brittle. you can reference an item by ID in css
154 </div>	163 </div>

155 <div class="maxiview" id="most-visited-maxiview"></div>	164 <div class="maxiview" id="most-visited-maxiview"></div>

156	165

157 <div class="sections">	166 <div class="sections">

158 <!-- Start disabled. We only enable once we have installed default apps. -->	167 <!-- Start disabled. We only enable once we have installed default apps. -->

159 <div id="apps" class="section disabled" section="APPS">	168 <div id="apps" class="section disabled" section="APPS">

160 <h2>	169 <h2>

161 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">	170 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">

162 <div class="back"></div>	171 <div class="back"></div>

163 <span i18n-content="apps"></span>	172 <span i18n-content="apps"></span>

(...skipping 150 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
314 var recentlyClosedInitiallyMenu = shownSections & MENU_RECENT;	323 var recentlyClosedInitiallyMenu = shownSections & MENU_RECENT;

315 setSectionMenuMode('apps', Section.APPS, appsInitiallyMenu, MENU_APPS);	324 setSectionMenuMode('apps', Section.APPS, appsInitiallyMenu, MENU_APPS);

316 setSectionMenuMode('most-visited', Section.THUMB, mostVisitedInitiallyMenu,	325 setSectionMenuMode('most-visited', Section.THUMB, mostVisitedInitiallyMenu,

317 MENU_THUMB);	326 MENU_THUMB);

318 setSectionMenuMode('recently-closed', undefined, recentlyClosedInitiallyMenu,	327 setSectionMenuMode('recently-closed', undefined, recentlyClosedInitiallyMenu,

319 MENU_RECENT);	328 MENU_RECENT);

320	329

321 layoutSections();	330 layoutSections();

322 </script>	331 </script>

323 </html>	332 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/ntp/apps.css » ('j') | chrome/browser/resources/ntp/apps.css » ('J')