BrowsingDataRemover: Getting ChromeAppCacheService directly from Profile.

BrowsingDataRemover: Getting ChromeAppCacheService directly from Profile.

BrowsingDataRemover was getting ChromeAppCacheService via URLRequestContextGetter
and (Chrome)URLRequestContext, even though Profile already has an accessor for it.

This also gets rid of the reinterpret_cast of casting URLRequestContext* to 
ChromeURLRequestContext*.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91327

[michaeln, 2011-07-01 01:40:40]

lgtm

[marja(google), 2011-07-01 16:49:47]

Changes as discussed yesterday. michaeln already said lgtm, but missing lgtm
from jochen still.

[commit-bot: I haz the power, 2011-07-01 18:28:32]

Change committed as 91327

[willchan no longer on Chromium, 2011-07-03 09:11:21]

http://codereview.chromium.org/7290025/diff/2001/chrome/browser/browsing_data...
File chrome/browser/browsing_data_remover.cc (right):

http://codereview.chromium.org/7290025/diff/2001/chrome/browser/browsing_data...
chrome/browser/browsing_data_remover.cc:228: waiting_for_clear_appcache_ = true;
Awesome! I was going to do this cleanup too. Glad to see you did the work for me
already. One thing I had done in my local changelist was mimic database_tracker_
above, where I don't post the task if appcache_service_ is NULL. I think that's
a minor improvement, so I thought I'd point it out. If you're busy, then no big
deal. Thanks for killing off that reinterpret_cast.

[marja(google), 2011-07-06 09:40:01]

http://codereview.chromium.org/7311001/

http://codereview.chromium.org/7290025/diff/2001/chrome/browser/browsing_data...
File chrome/browser/browsing_data_remover.cc (right):

http://codereview.chromium.org/7290025/diff/2001/chrome/browser/browsing_data...
chrome/browser/browsing_data_remover.cc:228: waiting_for_clear_appcache_ = true;
On 2011/07/03 09:11:21, willchan wrote:
> Awesome! I was going to do this cleanup too. Glad to see you did the work for
me
> already. One thing I had done in my local changelist was mimic
database_tracker_
> above, where I don't post the task if appcache_service_ is NULL. I think
that's
> a minor improvement, so I thought I'd point it out. If you're busy, then no
big
> deal. Thanks for killing off that reinterpret_cast.

I created another changelist for that http://codereview.chromium.org/7311001/ (I
guess that was what you meant?) Thanks for the feedback.