Issue 7289050: Fix stupid off-by-one crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7289050: Fix stupid off-by-one crash. (Closed)

Created:
9 years, 5 months ago by Peter Kasting

Modified:
9 years, 5 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix stupid off-by-one crash. BUG=88257 TEST=none TBR=erg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91389

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/tab_contents/infobar_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

9 years, 5 months ago (2011-07-06 17:28:27 UTC) #2

LGTM

On Fri, Jul 1, 2011 at 4:26 PM,  <pkasting@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Fix stupid off-by-one crash.
>
> BUG=88257
> TEST=none
> TBR=erg
>
> Please review this at http://codereview.chromium.org/7289050/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/tab_contents/infobar_container.cc
>
>
> Index: chrome/browser/tab_contents/infobar_container.cc
> ===================================================================
> --- chrome/browser/tab_contents/infobar_container.cc    (revision 91316)
> +++ chrome/browser/tab_contents/infobar_container.cc    (working copy)
> @@ -115,7 +115,7 @@
>
>   // TODO(pkasting): Remove this once TabContentsWrapper calls CloseSoon().
>   for (size_t i = infobars_.size(); i > 0; --i)
> -    infobars_[i]->CloseSoon();
> +    infobars_[i - 1]->CloseSoon();
>
>   ChangeTabContents(NULL);
>  }
>
>
>

Expand Messages | Collapse Messages