Issue 7289032: Remove SocketWrapper to expose the threading issues it masks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7289032: Remove SocketWrapper to expose the threading issues it masks. (Closed)

Created:
9 years, 5 months ago by Wez

Modified:
9 years, 5 months ago

Reviewers:
Sergey Ulanov, commit-bot: I haz the power

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove SocketWrapper, which should no longer be needed since we're explicitly telling writers not to touch channels in CloseInternal(). BUG= TEST=Unit-tests should pass. End-to-end remoting sessions should not make calls to deleted StreamSocket instances for channels during shutdown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91874

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -154 lines)			Patch
M	remoting/protocol/jingle_session.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	remoting/protocol/jingle_session.cc	View	1 2 3	4 chunks	+20 lines, -44 lines	0 comments	Download
D	remoting/protocol/socket_wrapper.h	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	remoting/protocol/socket_wrapper.cc	View		1 chunk	+0 lines, -52 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 91874

Expand Messages | Collapse Messages

Issue 7289032: Remove SocketWrapper to expose the threading issues it masks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Split ConnectionToHost changes out to separate CL. #

Patch Set 3 : Rebase, rinse and repeat. #

Patch Set 4 : Add missing bracket. #

Patch Set 5 : Rebase once more. #

Messages