Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6749)

Unified Diff: chrome/browser/prerender/prerender_final_status.cc

Issue 7289020: Updating histograms to allow for experiments & log origin-based histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_final_status.cc
===================================================================
--- chrome/browser/prerender/prerender_final_status.cc (revision 91002)
+++ chrome/browser/prerender/prerender_final_status.cc (working copy)
@@ -4,7 +4,6 @@
#include "chrome/browser/prerender/prerender_final_status.h"
-#include "base/metrics/histogram.h"
#include "chrome/browser/prerender/prerender_manager.h"
namespace prerender {
@@ -51,34 +50,6 @@
}
-void RecordFinalStatus(Origin origin, FinalStatus final_status) {
- DCHECK(final_status != FINAL_STATUS_MAX);
- // FINAL_STATUS_CONTROL_GROUP indicates that the PrerenderContents
- // was created only to measure "would-have-been-prerendered" for
- // control group measurements. Don't pollute data with it.
- if (PrerenderManager::IsControlGroup() ||
- final_status == FINAL_STATUS_CONTROL_GROUP)
- return;
- UMA_HISTOGRAM_ENUMERATION("Prerender.FinalStatus",
- final_status,
- FINAL_STATUS_MAX);
- switch (origin) {
- case ORIGIN_LINK_REL_PRERENDER:
- UMA_HISTOGRAM_ENUMERATION("Prerender.FinalStatus_LinkRelPrerender",
- final_status,
- FINAL_STATUS_MAX);
- break;
- case ORIGIN_OMNIBOX:
- UMA_HISTOGRAM_ENUMERATION("Prerender.FinalStatus_Omnibox",
- final_status,
- FINAL_STATUS_MAX);
- break;
- default:
- NOTREACHED();
- break;
- };
-}
-
const char* NameFromFinalStatus(FinalStatus final_status) {
DCHECK(static_cast<int>(final_status) >= 0 &&
static_cast<int>(final_status) <= FINAL_STATUS_MAX);

Powered by Google App Engine
This is Rietveld 408576698