Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8432)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 7289020: Updating histograms to allow for experiments & log origin-based histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
===================================================================
--- chrome/browser/prerender/prerender_browsertest.cc (revision 91002)
+++ chrome/browser/prerender/prerender_browsertest.cc (working copy)
@@ -98,7 +98,8 @@
int number_of_loads,
FinalStatus expected_final_status)
: PrerenderContents(prerender_manager, prerender_tracker, profile,
- url, referrer, ORIGIN_LINK_REL_PRERENDER),
+ url, referrer, ORIGIN_LINK_REL_PRERENDER,
+ PrerenderManager::kNoExperiment),
number_of_loads_(0),
expected_number_of_loads_(number_of_loads),
expected_final_status_(expected_final_status),
@@ -244,7 +245,8 @@
Profile* profile,
const GURL& url,
const GURL& referrer,
- Origin origin) OVERRIDE {
+ Origin origin,
+ char experiment_id) OVERRIDE {
cbentzel 2011/06/30 18:15:39 uint8 is better than char.
tburkard 2011/06/30 19:25:43 So use 255 then as "no experiment"? I think -1 is
dominich 2011/06/30 19:28:25 You can cast -1 to a uint8. Are the experiments g
tburkard 2011/06/30 19:45:48 Done.
tburkard 2011/06/30 19:45:48 Done.
CHECK(!expected_final_status_queue_.empty()) <<
"Creating prerender contents for " << url.path() <<
" with no expected final status";
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_contents.h » ('j') | chrome/browser/prerender/prerender_contents.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698