Basic HTTP pipelining support

net/http/http_stream_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_H_
 
 #include <list>
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "net/base/completion_callback.h"
 #include "net/base/load_states.h"
 #include "net/base/net_export.h"
 
 class GURL;
 
 namespace net {
 
 class BoundNetLog;
 class HostMappingRules;
 class HostPortPair;
 class HttpAlternateProtocols;
 class HttpAuthController;
 class HttpNetworkSession;
+class HttpPipelinedHost;
 class HttpResponseInfo;
 class HttpStream;
 class ProxyInfo;
 class SSLCertRequestInfo;
 class SSLInfo;
 class X509Certificate;
 struct HttpRequestInfo;
 struct SSLConfig;
 
 // The HttpStreamRequest is the client's handle to the worker object which
@@ skipping 130 matching lines @@
   // Requests that enough connections for |num_streams| be opened.
   virtual void PreconnectStreams(int num_streams,
                                  const HttpRequestInfo& info,
                                  const SSLConfig& server_ssl_config,
                                  const SSLConfig& proxy_ssl_config,
                                  const BoundNetLog& net_log) = 0;
 
   virtual void AddTLSIntolerantServer(const HostPortPair& server) = 0;
   virtual bool IsTLSIntolerantServer(const HostPortPair& server) const = 0;
 
+  // Called when a HttpPipelinedHost has new capacity. Attempts to allocate any
+  // pending pipeline-capable requests to pipelines.
+  virtual void OnHttpPipelinedHostHasAdditionalCapacity(

[willchan no longer on Chromium, 2011/09/29 23:36:02]

I consider pipelining an implementation detail. Not every HttpStreamFactory
implementation needs to support it. Therefore, I think you should move this
virtual to HttpStreamFactoryImpl.

[James Simonsen, 2011/10/12 01:36:58]

I tried this, but I didn't like it.

The pool gets access to the factory through the session. Changing this means the
session needs to return a FactoryImpl. That seems wrong.

An alternative would be to have the FactoryImpl own the pool, but that breaks
the symmetry with SPDY and I think the session is the right place for the pool.

My vote is to punt on this until we really do have different factories. Then we
can work it out.

[James Simonsen, 2011/10/13 19:29:57]

Done.

+      const HostPortPair& origin) = 0;
+
   // Static settings
   static GURL ApplyHostMappingRules(const GURL& url, HostPortPair* endpoint);
 
   // Turns spdy on or off.
   static void set_spdy_enabled(bool value) {
     spdy_enabled_ = value;
     if (value == false)
       set_next_protos("");
   }
   static bool spdy_enabled() { return spdy_enabled_; }
@@ skipping 34 matching lines @@
   // errors.  This is for testing.
   static void set_ignore_certificate_errors(bool value) {
     ignore_certificate_errors_ = value;
   }
   static bool ignore_certificate_errors() {
     return ignore_certificate_errors_;
   }
 
   static void SetHostMappingRules(const std::string& rules);
 
+  static void set_http_pipelining_enabled(bool value) {
+    http_pipelining_enabled_ = value;
+  }
+  static bool http_pipelining_enabled() { return http_pipelining_enabled_; }
+
  protected:
   HttpStreamFactory();
 
  private:
   static const HostMappingRules& host_mapping_rules();
 
   static const HostMappingRules* host_mapping_rules_;
   static const std::string* next_protos_;
   static bool spdy_enabled_;
   static bool use_alternate_protocols_;
   static bool force_spdy_over_ssl_;
   static bool force_spdy_always_;
   static std::list<HostPortPair>* forced_spdy_exclusions_;
   static bool ignore_certificate_errors_;
+  static bool http_pipelining_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_H_