Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7285031: Remove unmarked entries from per context map caches. (Closed)

Created:
9 years, 5 months ago by Vitaly Repeshko
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove unmarked entries from per context map caches. Made "map_cache" a weak field of global context and added a pass over all caches late in the marking phase. R=vegorov@chromium.org BUG=v8:1516 TEST=cctest/test-api/Regress1516 Committed: http://code.google.com/p/v8/source/detail?r=8515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -2 lines) Patch
M src/contexts.h View 2 chunks +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/mark-compact.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +57 lines, -0 lines 0 comments Download
M src/v8-counters.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 5 months ago (2011-07-01 11:49:37 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM We are cleaning the caches before processing weak references so we might end up ...
9 years, 5 months ago (2011-07-01 12:18:20 UTC) #2
Vitaly Repeshko
9 years, 5 months ago (2011-07-01 12:33:12 UTC) #3
On 2011/07/01 12:18:20, Vyacheslav Egorov wrote:
> LGTM
> 
> We are cleaning the caches before processing weak references so we might end
up
> cleaning more than actually will survive the collection. But this should not
> affect correctness.

Thanks! As we discussed this weak reference processing doesn't mark any objects.
Still it's a bit sad we have two traversals over the context list now. But I
don't see a good way to simplify it.


-- Vitaly

Powered by Google App Engine
This is Rietveld 408576698