[wip] Profile: Sketch of a creation system.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 277 matching lines @@
       start_time_(Time::Now()),
       spellcheck_host_(NULL),
       spellcheck_host_ready_(false),
 #if defined(OS_WIN)
       checked_instant_promo_(false),
 #endif
       delegate_(delegate) {
   DCHECK(!path.empty()) << "Using an empty path will attempt to write " <<
                             "profile files to the root directory!";
 
-#ifndef NDEBUG
-    ProfileDependencyManager::GetInstance()->ProfileNowExists(this);
-#endif
-
   create_session_service_timer_.Start(
       TimeDelta::FromMilliseconds(kCreateSessionServiceDelayMS), this,
       &ProfileImpl::EnsureSessionServiceCreated);

[Elliot Glaysher, 2011/06/30 23:55:03]

Why do we do this? Things seem to work if I leave this out.

[Miranda Callahan, 2011/07/01 15:20:24]

Good question. I tracked through the code and saw no clear reason to delay; svn
annotation says that this line was part of the original commit. Maybe the thing
to do is take it out in a CL on its own, so it's easier to track any possible
weird consequences (startup regressions, races between the session service
getting the initial BROWSER_OPENED notification, and the construction of the
profile (which is now partially asynchronous), unknown unknowns, etc. ...)

But removing 500ms delays that seem groundless sounds like a Very Good Thing.

 
   if (delegate_) {
     prefs_.reset(PrefService::CreatePrefService(
         GetPrefFilePath(),
         new ExtensionPrefStore(GetExtensionPrefValueMap(), false),
         true));
     // Wait for the notifcation that prefs has been loaded (successfully or
     // not).
     registrar_.Add(this, NotificationType::PREF_INITIALIZATION_COMPLETED,
                    Source<PrefService>(prefs_.get()));
@@ skipping 49 matching lines @@
   // Initialize the BackgroundModeManager - this has to be done here before
   // InitExtensions() is called because it relies on receiving notifications
   // when extensions are loaded. BackgroundModeManager is not needed under
   // ChromeOS because Chrome is always running (no need for special keep-alive
   // or launch-on-startup support).
 #if !defined(OS_CHROMEOS)
   if (g_browser_process->background_mode_manager())
     g_browser_process->background_mode_manager()->RegisterProfile(this);
 #endif
 
   BackgroundContentsServiceFactory::GetForProfile(this);

[Miranda Callahan, 2011/07/01 15:20:24]

Should be removed, along with a few other factory initializations in DoFinalInit
-- but you knew that.

[Elliot Glaysher, 2011/07/01 17:29:45]

I'm going to ignore the PinnedTabServiceFactory call for now.  There are a few
other things wrong with it that would be better to do all at once.

 
   extension_info_map_ = new ExtensionInfoMap();
 
   InitRegisteredProtocolHandlers();
 
   clear_local_state_on_exit_ = prefs->GetBoolean(prefs::kClearSiteDataOnExit);
   if (clear_local_state_on_exit_) {
     UserMetrics::RecordAction(
         UserMetricsAction("ClearSiteDataOnExitEnabled"));
   } else {
@@ skipping 427 matching lines @@
 
   // The last session exited cleanly if there is no pref for
   // kSessionExitedCleanly or the value for kSessionExitedCleanly is true.
   last_session_exited_cleanly_ =
       prefs_->GetBoolean(prefs::kSessionExitedCleanly);
   // Mark the session as open.
   prefs_->SetBoolean(prefs::kSessionExitedCleanly, false);
   // Make sure we save to disk that the session has opened.
   prefs_->ScheduleSavePersistentPrefs();
 
+  ProfileDependencyManager::GetInstance()->CreateProfileServices(this, false);
+
   // Ensure that preferences set by extensions are restored in the profile
   // as early as possible. The constructor takes care of that.
   extension_prefs_.reset(new ExtensionPrefs(
       prefs_.get(),
       GetPath().AppendASCII(ExtensionService::kInstallDirectoryName),
       GetExtensionPrefValueMap()));
 
   DCHECK(!net_pref_observer_.get());
   net_pref_observer_.reset(
       new NetPrefObserver(prefs_.get(), GetPrerenderManager()));
@@ skipping 810 matching lines @@
   if (!prerender::PrerenderManager::IsPrerenderingPossible())
     return NULL;
   if (!prerender_manager_.get()) {
     CHECK(g_browser_process->prerender_tracker());
     prerender_manager_.reset(
         new prerender::PrerenderManager(
             this, g_browser_process->prerender_tracker()));
   }
   return prerender_manager_.get();
 }