Issue 7285001: Add support for dictionary elements to polymorphic crankshaft code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7285001: Add support for dictionary elements to polymorphic crankshaft code. (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow

Modified:
9 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add support for dictionary elements to polymorphic crankshaft code. Committed: http://code.google.com/p/v8/source/detail?r=8479

Patch Set 2 : small fixes #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
M	src/hydrogen.cc	View	1	3 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with comments. http://codereview.chromium.org/7285001/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7285001/diff/1/src/hydrogen.cc#newcode3939 src/hydrogen.cc:3939: if (elements_kind == JSObject::DICTIONARY_ELEMENTS + 1 ...

9 years, 5 months ago (2011-06-29 14:16:35 UTC) #2

Updated version. I'll land this tomorrow morning.

Expand Messages | Collapse Messages

Issue 7285001: Add support for dictionary elements to polymorphic crankshaft code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : small fixes #

Messages