Cleaned up calling-related methods in the ARM assembler.

src/arm/assembler-arm.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 360 matching lines @@
 // -----------------------------------------------------------------------------
 // Machine instruction Operands
 
 // Class Operand represents a shifter operand in data processing instructions
 class Operand BASE_EMBEDDED {
  public:
   // immediate
   INLINE(explicit Operand(int32_t immediate,
          RelocInfo::Mode rmode = RelocInfo::NONE));
   INLINE(explicit Operand(const ExternalReference& f));
-  INLINE(explicit Operand(const char* s));
   explicit Operand(Handle<Object> handle);
   INLINE(explicit Operand(Smi* value));
 
   // rm
   INLINE(explicit Operand(Register rm));
 
   // rm <shift_op> shift_imm
   explicit Operand(Register rm, ShiftOp shift_op, int shift_imm);
 
   // rm <shift_op> rs
@@ skipping 767 matching lines @@
     }
 
    private:
     Assembler* assem_;
 
     DISALLOW_IMPLICIT_CONSTRUCTORS(BlockConstPoolScope);
   };
 
   // Debugging
 
+  // Check the code size generated from label to here.
+  int SizeOfCodeGeneratedSince(Label* l) { return pc_offset() - l->pos(); }

[Kevin Millikin (Chromium), 2011/06/30 08:55:02]

I'm not a fan of single character identifiers.  'l' is particularly bad.

[Sven Panne, 2011/06/30 09:29:48]

Me neither, but I'll have to admit being guilty of copy-n-paste. ;-) I'll change
this and the corresponding identifiers on the other platforms.

[Rodolph Perfetta, 2011/06/30 09:46:07]

There is already a method 'InstructionsGeneratedSince' in this file, do we need
both?

[Sven Panne, 2011/06/30 11:26:03]

InstructionsGeneratedSince can at least use SizeOfCodeGeneratedSince. It is a
bit unfortunate that the different assemblers don't agree in their
signatures/names for similar methods...

+
   // Mark address of the ExitJSFrame code.
   void RecordJSReturn();
 
   // Mark address of a debug break slot.
   void RecordDebugBreakSlot();
 
   // Record the AST id of the CallIC being compiled, so that it can be placed
   // in the relocation information.
   void RecordAstId(unsigned ast_id) { ast_id_for_reloc_info_ = ast_id; }
 
@@ skipping 219 matching lines @@
  public:
   explicit EnsureSpace(Assembler* assembler) {
     assembler->CheckBuffer();
   }
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM_ASSEMBLER_ARM_H_