Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 7284025: MIPS: port Remove the fcontext field from all contexts. (Closed)

Created:
9 years, 5 months ago by Paul Lind
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Remove the fcontext field from all contexts. Ported 8452 (8a2a360) Original commit message: Before: every context cached the nearest enclosing function context. This assumed that for nested contexts (i.e., with and catch contexts) the enclosing function had a materialized link in the context chain. Now: when necessary, we loop up the context chain to find such a context. This enables catch contexts without forcing the enclosing function to allocate its own context. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8477

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -11 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 5 months ago (2011-06-30 06:06:25 UTC) #1
Kevin Millikin (Chromium)
9 years, 5 months ago (2011-06-30 08:21:01 UTC) #2
LGTM, I'll commit it.

http://codereview.chromium.org/7284025/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (left):

http://codereview.chromium.org/7284025/diff/1/src/mips/macro-assembler-mips.c...
src/mips/macro-assembler-mips.cc:3723: if (emit_debug_code()) {
BTW, this debug check was removed from ARM because I couldn't think of a simple
way to do it with only one scratch register---and didn't want to pass in a
scratch register just for debug code.

It's still on IA32 and x64, so maybe you can think of a good way to introduce it
here?

Powered by Google App Engine
This is Rietveld 408576698